Changeset 769 for Whitix/branches

Timestamp:

07/09/08 18:46:34 (5 months ago)

Author:

mwhitworth

Message:

Fix vNode locking behaviour to avoid races.

Files:

• Whitix/branches/fs/fs/vfs/vcache.c (modified) (5 diffs)

Whitix/branches/fs/fs/vfs/vcache.c

@@ -98 +98 @@
         ListAddTail(&newNode->next,&superBlock->vNodeList);
 
+        VNodeLock(newNode);
+
         return newNode;
 }
@@ -208 +210 @@
                 return -EFAULT;
 
-        VNodeLock(vNode);
-
         if (vNode->superBlock && vNode->superBlock->sbOps && vNode->superBlock->sbOps->readVNode)
                 ret=vNode->superBlock->sbOps->readVNode(vNode);
@@ -224 +224 @@
         if (!vNode)
                 return -EFAULT;
-                
-        VNodeLock(vNode);
         
         if (vNode->superBlock && vNode->superBlock->sbOps && vNode->superBlock->sbOps->readVNodeWithData)
                 ret=vNode->superBlock->sbOps->readVNodeWithData(vNode, data);
-                
+
         VNodeUnlock(vNode);
         
@@ -280 +278 @@
 void VNodeSyncAll()
 {
-        struct VNode* curr;
+        struct VNode* curr, *curr2;
         struct VfsSuperBlock* superBlock;
 
         ListForEachEntry(superBlock,&sbList,sbList)
                 /* Cycle through all vNodes. */
-                ListForEachEntry(curr,&superBlock->vNodeList,next)
+                ListForEachEntrySafe(curr, curr2, &superBlock->vNodeList, next)
                         if (curr->flags & VNODE_DIRTY)
                                 VNodeWrite(curr);
@@ -345 +343 @@
                 free(vNode->extraInfo);
 
+        PreemptDisable();
         ListRemove(&vNode->next);
+        PreemptEnable();
 
         if (vNode->superBlock)